From ae6203938682945f90d1aac7f48852943393e2d3 Mon Sep 17 00:00:00 2001 From: Dale Hui Date: Thu, 17 Oct 2019 08:15:47 -0700 Subject: [PATCH] Add official support for firebird back --- Dockerfile | 2 +- Makefile | 2 +- README.md | 2 +- database/firebird/README.md | 6 ------ 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/Dockerfile b/Dockerfile index cb11b0b2e..cfab35537 100644 --- a/Dockerfile +++ b/Dockerfile @@ -8,7 +8,7 @@ WORKDIR /go/src/github.com/golang-migrate/migrate COPY . ./ ENV GO111MODULE=on -ENV DATABASES="postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb sqlserver" +ENV DATABASES="postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb sqlserver firebird" ENV SOURCES="file go_bindata github github_ee aws_s3 google_cloud_storage godoc_vfs gitlab" RUN go build -a -o build/migrate.linux-386 -ldflags="-s -w -X main.Version=${VERSION}" -tags "$DATABASES $SOURCES" ./cmd/migrate diff --git a/Makefile b/Makefile index a0cd24afe..291c179cc 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ SOURCE ?= file go_bindata github github_ee aws_s3 google_cloud_storage godoc_vfs gitlab -DATABASE ?= postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb sqlserver +DATABASE ?= postgres mysql redshift cassandra spanner cockroachdb clickhouse mongodb sqlserver firebird VERSION ?= $(shell git describe --tags 2>/dev/null | cut -c 2-) TEST_FLAGS ?= REPO_OWNER ?= $(shell cd .. && basename "$$(pwd)") diff --git a/README.md b/README.md index 6be55a90a..2f8af4de2 100644 --- a/README.md +++ b/README.md @@ -36,7 +36,7 @@ Database drivers run migrations. [Add a new database?](database/driver.go) * [Google Cloud Spanner](database/spanner) * [CockroachDB](database/cockroachdb) * [ClickHouse](database/clickhouse) -* [Firebird](database/firebird) ([todo #49](https://github.com/golang-migrate/migrate/issues/49)) +* [Firebird](database/firebird) * [MS SQL Server](database/sqlserver) ### Database URLs diff --git a/database/firebird/README.md b/database/firebird/README.md index 63a47723b..bdfef8aa9 100644 --- a/database/firebird/README.md +++ b/database/firebird/README.md @@ -10,9 +10,3 @@ | `role` | | Role name | | `tzname` | | Time Zone name. (For Firebird 4.0+) | | `wire_crypt` | | Enable wire data encryption or not. For Firebird 3.0+ (default is true) | - -## Not officially supported - -If you need a `migrate` CLI that supports Firebird, you'll need need to build it yourself. There are also no guarantees that the integration will work since we're not testing with Firebird. - -For more info, see: https://github.com/golang-migrate/migrate/issues/49#issuecomment-487193672