Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: inbuilt support for for int32/float32/[]byte slices in pq.Array #875

Closed
Shivam010 opened this issue Jun 20, 2019 · 2 comments
Closed

feature: inbuilt support for for int32/float32/[]byte slices in pq.Array #875

Shivam010 opened this issue Jun 20, 2019 · 2 comments

Comments

@Shivam010
Copy link
Contributor

For scanning int32 or float32 or []byte slices, we have to wrap a custom scanner/valuer around them to be able to use Scan/Value.

pq.Array does not have support for slices of 32 bit-size data-types.

The support should be added. I have a PR for it
@Shivam010 Shivam010 mentioned this issue Jun 20, 2019
Merged
@guenhter
Copy link

guenhter commented Dec 1, 2020

@Shivam010 I guess this can be closed, can't it?

@Shivam010
Copy link
Contributor Author

Yes indeed. Thanks to you, now I can be back to lib/pq instead of my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guenhter @Shivam010