Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem in picking up libgit2-7ce88e6 in fedora29 #1730

Open
adaggarwal opened this issue Oct 18, 2019 · 2 comments
Open

Problem in picking up libgit2-7ce88e6 in fedora29 #1730

adaggarwal opened this issue Oct 18, 2019 · 2 comments

Comments

@adaggarwal
Copy link

Reproduction steps

Build source-build without explicitly exporting LD_PATH in fedora29.

Expected behavior

libgit2-7ce88e6 gets picked up automatically from source-build dotnet path after it fails to find it in the environment

Actual behavior

Without explicitly exporting the path, this fails on fedora but passes in other distros such as centos and ubuntu

Version of LibGit2Sharp (release number or SHA1)

0e8a3ca
0.27.0-preview-0024

Operating system(s) tested; .NET runtime tested

fedora29 docker image
runtime - 2.1.0
@adaggarwal adaggarwal mentioned this issue Oct 18, 2019
Merged
@omajid
Copy link

omajid commented Nov 11, 2019

This should have been fixed by #1714.

@tmds
Copy link
Contributor

tmds commented Nov 13, 2019

fedora29 docker image
runtime - 2.1.0

This should have been fixed by #1714.

That fix applies to .NET Core 3.0+. Earlier versions don't have the NativeLibrary class that is used by the fix.

@omajid omajid mentioned this issue Nov 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omajid @tmds @adaggarwal