Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pygit2 1.0 was released ahead of required libgit2 release #968

Closed
ddevault opened this issue Jan 2, 2020 · 2 comments
Closed

pygit2 1.0 was released ahead of required libgit2 release #968

ddevault opened this issue Jan 2, 2020 · 2 comments

Comments

@ddevault
Copy link
Contributor

ddevault commented Jan 2, 2020

The latest libgit2 (0.28.4) does not include the changes from libgit2/libgit2#5005, which prevents pygit2 from building on the latest libgit2 version. Not sure what the appropriate change is, either rolling back #948 or asking libgit2 to prepare a new release.
@jdavid
Copy link
Member

jdavid commented Jan 4, 2020

No, #948 was merged after the release of 1.0

Though a new release of libgit2 would be nice, otherwise we cannot make a new release.

@ddevault
Copy link
Contributor Author

ddevault commented Jan 4, 2020

Sorry, I guess I got confused with the way the branches worked out.

And to ship a bugfix release, we could just cut a branch off of 1.0.1 and then cherry pick the bugfixes to include, and tag that. Doesn't need to be tagged from master.

@ddevault ddevault closed this as completed Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdavid @ddevault