Add AppStream metainfo #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choehwanjin
reviewed
Aug 5, 2018
data/Makefile.am
Outdated
| $(NULL) | ||
|
|
||
| CLEANFILES = $(appstream_DATA) |
There was a problem hiding this comment.
CLEANFILES = \
$(appstream_DATA) \
$(NULL)
과 같은 식으로 작성해주시면 좋겠습니다.
choehwanjin
reviewed
Aug 5, 2018
| </description> | ||
| <url type="homepage">https://github.com/libhangul/ibus-hangul</url> | ||
| <url type="bugtracker">https://github.com/libhangul/ibus-hangul/issues</url> | ||
| <translation type="gettext">ibus-hangul</translation> |
There was a problem hiding this comment.
<project_group>IBus</project_group> 태그를 추가하는 것은 어떤가요?
There was a problem hiding this comment.
<project_group> 태그 추가한 커밋 아이템과 하나로 합쳤으면 좋겠습니다.
There was a problem hiding this comment.
네 합쳤습니다. 👍
force push 계속하는 것보다는 squash merge하는 게 낫다고 생각해서 다른 커밋으로 넣었었습니다.
changwoo
force-pushed
the
59-add-appstream-metainfo
branch
from
4182747
to
fd68bbe
Compare
커밋 메시지에는 "Fixes https://github..." 식으로 URL이 쓰여 있습니다. 어떤 부분 말씀하시나요? |
|
GitHub에서만 로그를 봐서 URL로 작성된지 몰랐네요. |
changwoo
force-pushed
the
59-add-appstream-metainfo
branch
from
f492e8e
to
5083959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
혹시 맘에 안 드시는 부분 있으시면 (특히
<summary>나<description>) 환진님이 원하시는 대로 편집해 주세요.