Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics in go-libp2p #69

Closed
Tracked by #1356
p-shahi opened this issue May 11, 2023 · 6 comments · Fixed by #77
Closed
Tracked by #1356

metrics in go-libp2p #69

p-shahi opened this issue May 11, 2023 · 6 comments · Fixed by #77
Assignees

Comments

@p-shahi
Copy link
Member

p-shahi commented May 11, 2023

go-lipp2p has added metrics libp2p/go-libp2p#1356 across many components for better observability and debug-ability

Users have already found this effort useful. In order to widely announce this feature and showcase how to observe metrics (with examples), we should have an accompanying blog post.

@p-shahi
Copy link
Member Author

p-shahi commented May 11, 2023

@sukunrt Would you be up for taking this on?

@sukunrt
Copy link
Member

sukunrt commented May 11, 2023

I'll give it a try

@BigLep
Copy link
Contributor

BigLep commented Aug 22, 2023

I'm reopening because:

  1. I made some adjustments in Update metrics-in-go-libp2p.md #105
  2. I think we should provide more context arouund the "public dashboards": https://github.com/libp2p/go-libp2p/blob/master/dashboards/README.md#public-dashboards

About the dashboards:

  1. It's great we have these - thanks!
  2. In https://github.com/libp2p/go-libp2p/blob/master/dashboards/README.md#public-dashboards, lets add more context about these. Maybe something along the lines of:
These metrics come from one of the public IPFS DHT [bootstrap nodes](https://docs.ipfs.tech/concepts/nodes/#bootstrap) run by Protocol Labs.  At least of 202308, these nodes handle many connections across various libp2p implementations, versions, and. configurations.  They don't handle large file transfers.   

Concerning the dashboards themselves (e.g., https://protocollabs.grafana.net/public-dashboards/fce8fdeb629742c89bd70f0ce38dfd97?orgId=1 )

image

I'm missing context when I load it. A couple of things:

  1. Change to "go-libp2p Autonat" rather than "libp2p autonat"?
  2. Can we add a text panel that points back https://github.com/libp2p/go-libp2p/blob/master/dashboards/README.md#public-dashboards ? Basically something like See https://github.com/libp2p/go-libp2p/blob/master/dashboards/README.md#public-dashboards for more context.

@BigLep BigLep reopened this Aug 22, 2023
@p-shahi
Copy link
Member Author

p-shahi commented Aug 22, 2023

These metrics come from one of the public IPFS DHT [bootstrap nodes](https://docs.ipfs.tech/concepts/nodes/#bootstrap) run by Protocol Labs.  At least of 202308, these nodes handle many connections across various libp2p implementations, versions, and. configurations.  They don't handle large file transfers.   

Thanks! added: libp2p/go-libp2p#2508

@sukunrt can you address the points about dashboard naming and the text panel?

@sukunrt
Copy link
Member

sukunrt commented Aug 23, 2023

Thanks @BigLep for the suggestions. This context will be helpful for users.

Does this look good?
https://protocollabs.grafana.net/public-dashboards/fce8fdeb629742c89bd70f0ce38dfd97?orgId=1

@p-shahi
Copy link
Member Author

p-shahi commented Aug 23, 2023

It lgtm, @BigLep I'm going to close this, please re-open if something is amiss

@p-shahi p-shahi closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants