Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unsafe code #226

Open
turuslan opened this issue Nov 27, 2023 · 1 comment
Open

Refactor unsafe code #226

turuslan opened this issue Nov 27, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@turuslan
Copy link
Contributor

  • read/write lambda captures Bytes - use sptr<Bytes> or SharedFn
    • src/protocol/gossip/impl/stream.cpp Stream::beginWrite
@turuslan turuslan mentioned this issue Nov 27, 2023
Merged
@turuslan
Copy link
Contributor Author

Corrupted messages on "/ws" in YamuxedConnection::doWrite (seems like std::function or boost asio handler didn't move Bytes, but copied it)

@turuslan turuslan mentioned this issue Mar 30, 2024
Merged
@dhuseby dhuseby added the help wanted Extra attention is needed label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhuseby @turuslan