Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual DHT doesn't filter QueryEvents #602

Closed
willscott opened this issue Apr 22, 2020 · 0 comments · Fixed by #603
Closed

Dual DHT doesn't filter QueryEvents #602

willscott opened this issue Apr 22, 2020 · 0 comments · Fixed by #603

Comments

@willscott
Copy link
Contributor

the wrapper for multiple DHTs will result in a union of errors being emitted when a client asks to RegisterForQueryEvents. This means that if either DHT fails, some clients may interpret the overall call as a failure and give up.

The Dual DHT should generate sub-contexts for its WAN and LAN DHTs, and route these events in the same way that it streams and combines other asynchronous output from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant