Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestGround tests for higher usefulness interval #654

Closed
aarshkshah1992 opened this issue May 22, 2020 · 1 comment
Closed

TestGround tests for higher usefulness interval #654

aarshkshah1992 opened this issue May 22, 2020 · 1 comment

Comments

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented May 22, 2020

In #651:

We introduced a change to double the usefulness interval i.e. the grace period we give to peers to be deemed "useful"(faster response to queries) before we replace them in the Routing Table in favour of a new peer.

Earlier, an attacker could create too many connections to us causing us to disconnect peers we have in our RT. This would then affect their "usefulness" scores(since we measure usefulness by query response latency) as the query time would have to pay the connection cost for them. Hence, we'd evict them through no fault of theirs, thus giving the attacker space in the RT.

Now, that's harder because you'd have to cause more disconnects to cause a low usefulness score for a a prolonged duration.

However, this could hurt performance as we'll keep slow peers in the RT around for longer too.

We could test all this using the TG. Need to discuss if it's worth it though.

@Stebalien
Copy link
Member

We've gotten rid of usefulness so this is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants