Port query-oriented tests from v1 to v2

[iand]

Port all the tests that rely on query behaviour to v2 to ensure we follow existing behaviours as closely as possible.

Tasks

Beta Give feedback

1. Test query interactions with routing table #887
   v2 +1
   

[guillaumemichel]

We need to be careful not to transfer the flaky tests.

[BigLep]

Do we have metrics to see what our test coverage is?

[dennis-tra]

Current stats of v2-develop all files in the v2 subdirectory:

• 220 tests
• 93.8% of files tested
• 69.3% of statements tested

[BigLep]

Thanks @dennis-tra for the stats. I should have been more clear to make sure we have a mechanism in place to ensure good test coverage, something along the lines of:

1. Measurements are automatically produced
2. They're included in a PR
3. We have gates that requires new code to have at least X% coverage
   etc.

[dennis-tra]

@BigLep ah sorry, yup, that's already happening! Here's an example from a recent PR:

However, the metrics are included in the PR as a comment. Also, we don't have a gate that requires a certain coverage percentage. I would also a be bit skeptical about the merit of such a gate.

[iand]

The majority of these have now been done as part of implementation of the routing.Routing interface methods