Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StartSpan function from tele package #927

Closed
dennis-tra opened this issue Sep 19, 2023 · 1 comment
Closed

Remove StartSpan function from tele package #927

dennis-tra opened this issue Sep 19, 2023 · 1 comment
Assignees
@iand
Labels
nice-to-have Not required but certainly a nice thing to have v2 All issues related to the v2 rewrite

Comments

@dennis-tra
Copy link
Contributor

We should remove this function:

go-libp2p-kad-dht/v2/tele/tele.go

Line 133 in e86381e

func StartSpan(ctx context.Context, name string, opts ...trace.SpanStartOption) (context.Context, trace.Span) {

Instead we should plumb a tracer through to the pool/probe/etc.

Context: #924 (comment)
@dennis-tra dennis-tra mentioned this issue Sep 19, 2023
Merged
@dennis-tra dennis-tra added v2 All issues related to the v2 rewrite nice-to-have Not required but certainly a nice thing to have labels Sep 19, 2023
@iand iand mentioned this issue Oct 2, 2023
Open
@iand
Copy link

iand commented Oct 2, 2023

Migrated to probe-lab/zikade#32

@iand iand closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iand iand

Labels
nice-to-have Not required but certainly a nice thing to have v2 All issues related to the v2 rewrite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iand @dennis-tra