Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IpfsDHT.GatValue method causes memory growth #958

Closed
godeamon opened this issue Nov 17, 2023 · 1 comment · Fixed by #960
Closed

IpfsDHT.GatValue method causes memory growth #958

godeamon opened this issue Nov 17, 2023 · 1 comment · Fixed by #960

Comments

@godeamon
Copy link
Contributor

godeamon commented Nov 17, 2023 •
edited
Loading

image This flame graph is the memory graph where I keep calling the GatValue method. If I keep calling, the memory keeps going up. Here is my code: https://github.com/OpenAtomFoundation/xupercore/blob/v5.3.0/bcs/network/p2pv2/server.go#L362C29-L362C29

I'm not sure if I'm using it the wrong way or if there's a memory leak.

github.com/libp2p/go-libp2p-kad-dht v0.25.1 also has this problem.
@godeamon godeamon mentioned this issue Nov 21, 2023
Merged
@godeamon
Copy link
Contributor Author

godeamon commented Nov 21, 2023 •
edited
Loading

PR: #960

@guillaumemichel guillaumemichel linked a pull request Nov 28, 2023 that will close this issue
add ctx canceled err check #960
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ctx canceled err check godeamon/go-libp2p-kad-dht
1 participant
@godeamon