Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

make sure the packet conn exposes UDPConn functions #178

Closed
marten-seemann opened this issue Oct 19, 2020 · 1 comment · Fixed by #180
Closed

make sure the packet conn exposes UDPConn functions #178

marten-seemann opened this issue Oct 19, 2020 · 1 comment · Fixed by #180
Labels
exp/expert Having worked on the specific codebase is important

Comments

@marten-seemann
Copy link
Collaborator

quic-go uses interface assertion to test for functions specific to the net.UDPConn, e.g. SetReadBuffer(). Since our net.PacketConn wraps the UDPConn in multiple layers, the interface assertion will fail (see https://play.golang.org/p/GHDrrvwaI2c for a minimal example), thus disabling optimization that should be possible.

Note that this might require changes to quic-go.

@marten-seemann marten-seemann added the exp/expert Having worked on the specific codebase is important label Oct 19, 2020
@marten-seemann
Copy link
Collaborator Author

#180 is the better solution to this than the rather ugly quic-go/quic-go#2830.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/expert Having worked on the specific codebase is important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant