Libp2p now loses all peers when upgrading to 0.26.2 from 0.24.0 #2202
Comments
Giulio2002
changed the title
Giulio2002
changed the title
Giulio2002
changed the title
|
Tried to downgrade to 0.25 as well but same issue there too |
|
We removed identify delta in v0.25:
I don't understand. A request is asking you to remove that stream handler? Or do you mean there are requests on the network for What if you had a no-op implementation for e.g.: |
|
I mean that removing that handler somehow makes it work again but only for gossip, if I do requests i start getting disconnected. NOTE: I am not sure if it is me banning somehow or them banning me, what I know is that after 8-9 hours of sending requests I lose all my peers and cannot reconnect again |
|
Could it be that the other clients of the network uses a lower libp2p version and that is causing issues, perhaps? because none of them are running the latests in any release. If you are wondering how I came out with the identify.IdDelta fixup was that I compared it to prysm (another ETH 2.0 client) and it seems that they did remove IdDelta. So i just hardcoded the value and it just worked for as long as I do not make any requests, before it just randomly used to disconnect. Also I am now testing your snippet. |
|
still dies with handler |
This is strange. We don't have that handler registered so removing it should be a no-op? |
|
Prysm is on go-libp2p v0.26.2 and we haven't gotten an issue from them yet. This might be an issue with your specific setup. Maybe some action is negatively affecting your gossipsub peer score? |
|
mmmh, i see... I will see what I can do, If I find something out I will write it here, you can close this issue if you wish btw :) |
|
Ok but hold up a second, this commit erigontech/erigon@d5bb424 (do not worry this is just the |
|
Can you run with |
|
I wonder what the difference is in those logs. |
|
Update: it seems that disbabling pubsub makes the request not kick me again, i think it is a libp2p-go pubsub issue. should I move it to their repo? |
|
Yes please. Tag me there as well and reference this issue. |
|
btw i have the feelings that these logs are going to be long, should I cut them? It will take a few days as my application needs to run for 12 hours before dying |
|
here is a taste though of the broken version logs: |
post death. full log file is 29 GB so probably it is better cut. |
|
Anything stand out to you? Maybe log at a warn level instead? |
|
warn: for broken for not broken |
|
same thing pretty much. i think I will try to test all pubsub version until implosion in beetwen |
|
look, this is not a pubsub issue, it is a libp2p regression that breaks pubsub. |
|
Anyway at this point I will just use Prysm config where possible even though It is quite messy. will leave open for closure in case. |
What regression? |
|
the only thing that has changed is libp2p, which keeps changing too fast for not particularly good reasons and without proper regression testing... and now that network is broken. |
|
@Giulio2002 if you want to hop on a call to pair debug this I’m happy to do so. We can coordinate on filecoin slack: https://filecoin.io/slack |
|
DMed you, text me whenever... i think we are on different timezones though |
|
Per our out of band discussion, this isn't losing peers. Rather the "subscription to gossip seems not to count new peers after a while". I think we can close this issue, but can maybe reopen another issue when we root cause the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Hello, I am from the Erigon team, one of the Ethereum clients, I am trying to build a consensus client and I am having issues after upgrading libp2p to 26.2. What seems to happen is that after the upgrade I lose all the peers I have and get kicked out of the network eventually. I found a work around that seems to somehow fix this as long as I do not do any request which is calling
host.RemoveStreamHandler("/p2p/id/delta/1.0.0"). If I do that when I only subscribe and publish to gossip it seems to not give any issue, however if I repeatedly make requests to the network, I will get kicked out from the network (or at least lose all peers and be unable to reconnect).I get kicked out after a while from the ETH 2.0 network after upgrading libp2p version.
The text was updated successfully, but these errors were encountered: