Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for specifying how to create a set of tests #9

Open
Mikerah opened this issue Mar 13, 2019 · 3 comments
Open

Update docs for specifying how to create a set of tests #9

Mikerah opened this issue Mar 13, 2019 · 3 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Mikerah
Copy link

Mikerah commented Mar 13, 2019

I think the tests in this repo should conform to the same format. This will make it easier to start new tests for different functionality and onboard new contributors that want to help in adding interop tests.

Any thoughts?

@vasco-santos
Copy link
Member

Hello @Mikerah

We decided a format for the tests, but it is not clear in the README and it should be!

Basically, for each type of tests, we create a specific folder for it and then, inside of this folder, we create folders representing the way implementations are being tested. You can check the current tests, as well as the DHT PR in this repo.

Do you have any other suggestions?

@Mikerah
Copy link
Author

Mikerah commented Mar 13, 2019

@vasco-santos thanks for the reply. Should I keep this issue open until the details of how to format tests are added to the README? Or should I create a separate issue for that?

@vasco-santos vasco-santos changed the title Formats for tests Update docs for specifying how to create a set of tests Mar 13, 2019
@vasco-santos vasco-santos added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up labels Mar 13, 2019
@vasco-santos
Copy link
Member

I updated the name of the issue and the labels for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants