Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

chore: change min node support to 16 #230

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented Jan 6, 2022

This library does not work with node 15 (#221).
Moreover, node 15 has reached End-of-Life.

Resolves #221.

This library does not work with node 15 (libp2p#221).
Moreover, node 15 has reached End-of-Life.

Resolves libp2p#221.
@achingbrain
Copy link
Member

achingbrain commented Jan 8, 2022

Weird that, 'jwk' is a supported option for node 15 as per the docs.

Officially these modules support LTS and Current only so this change makes sense.

@achingbrain achingbrain changed the title Change min node support to 16 chore: change min node support to 16 Jan 8, 2022
@achingbrain achingbrain merged commit 9aabfe6 into libp2p:master Jan 8, 2022
github-actions bot pushed a commit that referenced this pull request Jan 8, 2022
### [0.22.4](v0.22.3...v0.22.4) (2022-01-08)

### Trivial Changes

* change min node support to 16 ([#230](#230)) ([9aabfe6](9aabfe6)), closes [#221](#221)
* **deps:** bump node-forge from 0.10.0 to 1.1.0 ([#231](#231)) ([d33eea1](d33eea1))
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

🎉 This PR is included in version 0.22.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@D4nte
Copy link
Contributor Author

D4nte commented Jan 10, 2022

Weird that, 'jwk' is a supported option for node 15 as per the docs.

Officially these modules support LTS and Current only so this change makes sense.

Yes but it's a bug (nodejs/node#39205) that prevents the usage of 'jwk'. The bug was fixed for 16 after EOL of 15.

@D4nte D4nte deleted the node-16-min-support branch January 10, 2022 03:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 15: The property 'options.publicKeyEncoding.format' is invalid. Received 'jwk'
2 participants