fix: avoid race condition on unsubscribe

libp2p · May 16, 2017 · 8cf5498 · 8cf5498
1 parent e8a3ef6
commit 8cf5498
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -332,9 +332,15 @@ class FloodSub extends EventEmitter {
       this.subscriptions.delete(topic)
     })
 
-    this.peers.forEach((peer) => {
-      peer.sendUnsubscriptions(topics)
-    })
+    this.peers.forEach((peer) => checkIfReady(peer))
+    // make sure that FloodSub is already mounted
+    function checkIfReady (peer) {
+      if (peer && peer.isWritable) {
+        peer.sendUnsubscriptions(topics)
+      } else {
+        setImmediate(checkIfReady.bind(peer))
+      }
+    }
   }
 }