This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat: split out code, convert to typescript #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
feat/split-out-code
branch
from
e9d383a
to
85f8dfc
Compare
achingbrain
changed the title
achingbrain
force-pushed
the
feat/split-out-code
branch
from
85f8dfc
to
2909163
Compare
achingbrain
force-pushed
the
feat/split-out-code
branch
from
2909163
to
0fedfa0
Compare
* Splits implementations out from interfaces so we can depend on interfaces module without pulling in crypto, etc (fixes #110) * Converts code to typescript (fixes #101) * Adds types for PeerData and Registrar - these will need to be fleshed out properly in a subsequent PR BREAKING CHANGE: not all fields from concrete classes have been added to the interfaces
achingbrain
force-pushed
the
feat/split-out-code
branch
from
0fedfa0
to
42e2ed5
Compare
vasco-santos
approved these changes
Nov 8, 2021
| "bugs": { | ||
| "url": "https://github.com/libp2p/js-libp2p-interfaces/issues" | ||
| }, | ||
| "homepage": "https://github.com/libp2p/js-libp2p-interfaces/tree/master/packages/libp2p-connection#readme#readme", |
There was a problem hiding this comment.
Can we add a placeholder Readme file?
|
🎉 This PR is included in version @libp2p/interfaces-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/topology-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/connection-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/pubsub-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
43 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to break some of the circular dependencies in the interfaces (e.g. libp2p depends on pubsub, which depends on libp2p, which depends on pubsub, etc). This hasn't been possible in the tests so I've added
@ts-expect-errorwhere we access these properties with the aim to revisit it once this has been rolled up to libp2p itself.BREAKING CHANGE: not all fields from concrete classes have been added to the interfaces, some adjustment may be necessary as this gets rolled out