This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix: update dialer tests #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mockUpgrader` is supposed to accept a `MultiaddrConnection` and return a `Connection`, but it just passes through the `MultiaddrConnection`. This is a problem as the two types are not compatible. This shows up in our code as our tests treat `Connection`s as if they are something you can pass to `it-pipe` but they are not. This PR fixes up the `mockUpgrader` to return something compatible with the `Connection` interface. It also removes a few of the dialer tests that were only testing the newly introduced mock code.
achingbrain
added a commit
to libp2p/js-libp2p-tcp
that referenced
this pull request
Dec 10, 2021
Converts this module to typescript Depends on: - [ ] libp2p/js-libp2p-interfaces#116 BREAKING CHANGE: this module now uses the updated libp2p-interfaces module
1 task
|
🎉 This PR is included in version @libp2p/interfaces-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @libp2p/connection-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mockUpgraderis supposed to accept aMultiaddrConnectionand return aConnection, but it just passes through theMultiaddrConnection.This is a problem as the two types are not compatible. This shows up in our code as our tests treat
Connections as if they are something you can pass toit-pipebut they are not, you have to get aMuxedStreamfromconn.netStream([str])for that.This PR fixes up the
mockUpgraderto return something compatible with theConnectioninterface. It also removes a few of the dialer tests that were only testing the newly introduced mock code.