Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[transport] Listener.listen should support an array of multiaddrs #29

Closed
jacobheun opened this issue Nov 9, 2018 · 2 comments
Closed

Comments

@jacobheun
Copy link
Contributor

Per libp2p/js-libp2p-websocket-star#61 (comment) it would be helpful if Listener.listen would support an array of multiaddrs. Since libp2p is likely to have multiple addresses for a single transport, enabling that transport to better control all it's listeners internally, including the proposed accept/reject additions libp2p/interface-transport#39, would make using the transports simpler.

@jacobheun
Copy link
Contributor Author

Once this has been added, we should update the transports that use this interface. https://github.com/libp2p/interface-transport#modules-that-implement-the-interface

@daviddias daviddias changed the title Listener.listen should support an array of multiaddrs [transport] Listener.listen should support an array of multiaddrs Feb 5, 2020
@daviddias daviddias transferred this issue from libp2p/interface-transport Feb 5, 2020
@jacobheun
Copy link
Contributor Author

This is no longer needed at the transport level. The new libp2p TransportManager (as of v0.27) will create a listener for each multiaddr and manage the listeners accordingly. This keeps the complexity out of the transports.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant