fix: no more circular dependency, become a good block of libp2p #13

daviddias · 2017-07-16T12:33:56Z

Fix #9. Just one last thing, fix:

 1) KadDHT put - get:
   Uncaught TypeError: pi.id.toB58String is not a function
    at Swarm.dial (node_modules/libp2p-swarm/src/dial.js:22:25)
    at Network.sendRequest (src/network.js:143:20)
    at KadDHT._findPeerSingle (src/private.js:244:17)

by leveling up swarm.dial to also support PeerId instead of just PeerInfo.

dignifiedquire · 2017-07-17T08:02:38Z

src/index.js


    /**
-     * Number of closest peers to return on kBucket search
+     * Number of closest peers to return on kBucket search, default 20


this is not 20 in the code but 6

dignifiedquire · 2017-07-17T08:07:13Z

test/kad-dht.spec.js

@@ -11,23 +11,26 @@ const timeout = require('async/timeout')
 const retry = require('async/retry')


👎 for the rename

pgte

Not too familiar with DHT internals, but apart from one comment, the javascript look solid :)

pgte · 2017-07-17T10:53:36Z

src/index.js

   */
-  constructor (libp2p, kBucketSize, datastore) {
+  constructor (swarm, options) {
+    assert(swarm, 'libp2p-kad-dht requires a instance of kad-dht')


don't you mean "libp2p-kad-dht requires a instance of swarm"?

daviddias · 2017-07-17T14:33:09Z

CI is failing due to previously reported bug: #8

Passes locally.

fix: no more circular dependency, become a good block of libp2p

96f2af8

daviddias force-pushed the fix/circular-dep branch 2 times, most recently from 3c41724 to e795c8c Compare July 17, 2017 08:00

dignifiedquire reviewed Jul 17, 2017

View reviewed changes

there were more tests :) fix remaining things, test with new swarm ✔️

ee64411

daviddias force-pushed the fix/circular-dep branch from e795c8c to ee64411 Compare July 17, 2017 09:07

daviddias added 2 commits July 17, 2017 02:13

apply cr

3097787

fix docs

aab4fe4

daviddias requested a review from pgte July 17, 2017 09:26

pgte suggested changes Jul 17, 2017

View reviewed changes

apply cr

b13bb9f

daviddias merged commit 810be4d into master Jul 17, 2017

daviddias deleted the fix/circular-dep branch July 17, 2017 14:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: no more circular dependency, become a good block of libp2p #13

fix: no more circular dependency, become a good block of libp2p #13

daviddias commented Jul 16, 2017 •

edited

Loading

dignifiedquire Jul 17, 2017

dignifiedquire Jul 17, 2017

pgte left a comment

pgte Jul 17, 2017

daviddias commented Jul 17, 2017 •

edited

Loading

		@@ -11,23 +11,26 @@ const timeout = require('async/timeout')
		const retry = require('async/retry')

fix: no more circular dependency, become a good block of libp2p #13

fix: no more circular dependency, become a good block of libp2p #13

Conversation

daviddias commented Jul 16, 2017 • edited Loading

dignifiedquire Jul 17, 2017

Choose a reason for hiding this comment

dignifiedquire Jul 17, 2017

Choose a reason for hiding this comment

pgte left a comment

Choose a reason for hiding this comment

pgte Jul 17, 2017

Choose a reason for hiding this comment

daviddias commented Jul 17, 2017 • edited Loading

daviddias commented Jul 16, 2017 •

edited

Loading

daviddias commented Jul 17, 2017 •

edited

Loading