This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: actually send the add provider rpc with addresses #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Jul 10, 2020
vasco-santos
approved these changes
Jul 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was adding some additional tests post #200 which exposed a couple issues with provide calls.
ADD_PROVIDERrpc was never being sent, as no sync was set up in the pipe. This corrects that withconsume.libp2p@0.28.5includes a patch to pass libp2p to the dht constructor to give it access. We can simplify the constructor in a future breaking change.The reason the tests didn't catch this is that the dht connects to and queries the provider, but they can't do this with a dht client, they need to get the provider record from another DHT server. Since the provider record wasn't actually being sent, the new tests failed.