Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix: dht get options #40

Merged
merged 1 commit into from
Sep 20, 2018
Merged

fix: dht get options #40

merged 1 commit into from
Sep 20, 2018

Conversation

vasco-santos
Copy link
Member

Changed dht.get and dht.getMany maxTimeout parameter to an options parameter with the maxTimeout property as discussed here.

@ghost ghost assigned vasco-santos Sep 20, 2018
@ghost ghost added the status/in-progress In progress label Sep 20, 2018
@vasco-santos vasco-santos mentioned this pull request Sep 20, 2018
Merged
1 task
jacobheun
jacobheun approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows on Jenkins is not having a good day, the changes look good.

@vasco-santos
Copy link
Member Author

Thanks for the review @jacobheun ! I will restart the CI to get it green

@vasco-santos vasco-santos mentioned this pull request Sep 20, 2018
Merged
35 tasks
@vasco-santos vasco-santos merged commit 0a2f9fe into master Sep 20, 2018
@vasco-santos vasco-santos deleted the fix/dht-get-options branch September 20, 2018 17:25
@ghost ghost removed the status/in-progress In progress label Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@daviddias daviddias Awaiting requested review from daviddias

Assignees

@vasco-santos vasco-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @jacobheun