This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: update options timeout property #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: get, getMany, findProviders and findPeer do not accept a timeout number anymore. It must be a property of an object options.
ghost
assigned 
|
coverage decreases as we are still supporting |
fsdiogo
suggested changes
Dec 11, 2018
35 tasks
Co-Authored-By: vasco-santos <vasco.santos@ua.pt>
fsdiogo
approved these changes
Dec 11, 2018
alanshaw
reviewed
Dec 11, 2018
| if (!options.maxTimeout) { | ||
| options.maxTimeout = c.minute | ||
| if (!options.maxTimeout && !options.timeout) { | ||
| options.timeout = 'c.minute' // default |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxTimeoutoption property renamed totimeout. Moreover, previous support for timeout using a number instead of an object with options deprecated.BREAKING CHANGE: get, getMany, findProviders and findPeer do not accept a timeout number anymore. It must be a property of an object options.