This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: put query for closest peers #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
fix/put-query-for-closest-peers
branch
from
1dd3f43
to
23635ae
Compare
jacobheun
suggested changes
Mar 1, 2019
src/index.js
Outdated
| * @param {function(Error, Array<PeerId>)} callback | ||
| * @returns {void} | ||
| */ | ||
| getClosestPeers (key, callback) { | ||
| getClosestPeers (key, isOneIteration, callback) { |
There was a problem hiding this comment.
isOneIteration should be an options object for better future proofing.
There was a problem hiding this comment.
We'll likely refactor this away anyway, but perhaps it might be good to use a more generic term like shallow, as it's possible we may use that later. The name change isn't a blocker though.
There was a problem hiding this comment.
agree, I have updated!
vasco-santos
force-pushed
the
fix/put-query-for-closest-peers
branch
from
23635ae
to
7b80020
Compare
jacobheun
approved these changes
Mar 4, 2019
|
I will open the issue for revisiting this logic! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a big number of peers, the query does not stop and put hangs, also hitting heavily the CPU. Moreover, we will get a really big set of peers from the
closestPeersand trying to put to all of them also cause problems, as some end up failing, which causes the put operation to fail.In a long run, we have to refactor the
closestPeersandquerylogic to be more fault tolerant. We should stream the query as we would be able to stop the query at a certain point (should have an abort logic). I will create an issue for this afterward.