This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: do not emit empty peer info objects #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed stack traces in the logs from trying to access properties of `undefined`. It seems this module emits `undefined` `peerInfo` values, for example when recieving a response to your own mDNS query or a response with an invalid PeerID. This PR guards on empty PeerInfo objects from `query.gotResponse`
|
released in 0.13.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed stack traces in the logs from trying to access properties of
undefined. It seems this module emitsundefinedpeerInfovalues, for example when recieving a response to your own mDNS query or a response with an invalid PeerID.This PR guards on empty PeerInfo objects from
query.gotResponse