This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix!: emit uint8arraylists for data #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure there's no chance we end up copying memory to a new location only to pass it to a stream handler, return `Uint8ArrayList`s for the `data` property of multiplexed messages. The stream interface looks like this: ``` Stream extends Duplex<Uint8ArrayList, Uint8ArrayList | Uint8Array> ``` That is, it's a Duplex whose source emits `Uint8ArrayList`s but the sink can accept `Uint8ArrayList`s or `Uint8Arrays`. Depends on: - [ ] libp2p/js-libp2p-interfaces#279
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
## [5.0.0](v4.0.3...v5.0.0) (2022-08-10) ### ⚠ BREAKING CHANGES * mulitplexed streams now emit `Uint8ArrayList`s and not `Uint8Array`s to handle the case for when transports have smaller chunk sizes than the multiplexer ### Bug Fixes * emit uint8arraylists for data ([#201](#201)) ([e85ebab](e85ebab))
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure there's no chance we end up copying memory to a new
location only to pass it to a stream handler, return
Uint8ArrayListsfor the
dataproperty of multiplexed messages.The stream interface looks like this:
That is, it's a Duplex whose source emits
Uint8ArrayLists but thesink can accept
Uint8ArrayLists orUint8Arrays.Depends on:
BREAKING CHANGE: mulitplexed streams now emit
Uint8ArrayLists and notUint8Arrays to handle the case for when transports have smaller chunk sizes than the multiplexer