Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: porting to new aegir #70

Merged
merged 6 commits into from
Dec 14, 2017
Merged

feat: porting to new aegir #70

merged 6 commits into from
Dec 14, 2017

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Dec 12, 2017

No description provided.

@ghost ghost assigned dryajov Dec 12, 2017
@ghost ghost added the status/in-progress In progress label Dec 12, 2017
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dryajov can you npm link this change and test it? I've experienced some issues with the latest pump in js-ipfs-api.

@dryajov
Copy link
Member Author

dryajov commented Dec 12, 2017

@diasdavid you want me to test this against js-ipfs or ipfs-api? (I'll do both either way, just wanted to make sure)

@dryajov
Copy link
Member Author

dryajov commented Dec 12, 2017

@diasdavid a test in interface-stream-muxer is timing out in browser runs, I wonder whats' the best way of handling it, increase it on the test itself or add a global timeout? Not sure if setting the timeout in the generic tests would be the right way to go?

@dryajov
Copy link
Member Author

dryajov commented Dec 12, 2017

@diasdavid I've set the timeout globally for now, unless you want me to make the change on the interface tests them self.

@dryajov
Copy link
Member Author

dryajov commented Dec 13, 2017

I'm currently getting

  1) HTTP API
       ## interface-ipfs-core over ipfs-api
         .files
           .cat
             errors on unknown path:
     AssertionError: expected 'Failed to cat file: Error: No such file' to be one of [ Array(2) ]
      at ipfs.files.cat.catch (node_modules/interface-ipfs-core/src/files.js:439:36)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)

when running test for js-ipfs locally. It happens for both, when linking this module or with nothing linked at all. I doubt it is related to this change, though.

@daviddias
Copy link
Member

a test in interface-stream-muxer is timing out in browser runs

Increase in the test itself (as usual)

#70 (comment)

Sounds good then :)

@daviddias daviddias merged commit 30fc825 into master Dec 14, 2017
@daviddias daviddias deleted the fix/update-aegir branch December 14, 2017 06:05
@ghost ghost removed the status/in-progress In progress label Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants