Default value for self emit option

[vasco-santos]

Our floodsub implementation was self-emitting, pubsub messages if the node has previously subscribed to that topic. However, users may not expect this to happen and this is not clear at the moment.

In this context, I created PRs to allow this to be configurable:

libp2p/js-libp2p-floodsub#85
ChainSafe/gossipsub-js#40

In this context, I opened this issue for discussing whether we should continue with this default behaviour in js-libp2p, or change this to false.

cc @jacobheun

[a1300]

@vasco-santos related to libp2p/js-libp2p#401

[vasco-santos]

@a1300 any opinions on keeping the default to true or move to false?

[a1300]

Personally I would leave the defaults for the options signMessages and strictSigning to true but the default for emitSelf I would change to false because I didn't expected that I would need to handle this case.

cc @vasco-santos @jacobheun

[jacobheun]

I agree that emitSelf should be false by default, the current default behavior is counter intuitive.

[vasco-santos]

I will work on changing that

[vasco-santos]

It defaults to false now both on floodsub and gossipsub