Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Ensure compatibility with pubsub spec changes regarding messageIDs #67

Closed
rklaehn opened this issue Jul 25, 2020 · 2 comments
Closed

Ensure compatibility with pubsub spec changes regarding messageIDs #67

rklaehn opened this issue Jul 25, 2020 · 2 comments
Labels
status/ready Ready to be worked

Comments

@rklaehn
Copy link

rklaehn commented Jul 25, 2020

proto format for messageIDs in gossipsub has been changed from string to bytes. Long story, all the gory details are referenced from the PR libp2p/specs#285 .

Js gossipsub should ensure that everything works fine with non-utf8 message ids. If that is already the case, feel free to close this issue. Just wanted to make you aware.
@rklaehn rklaehn changed the title Ensure compatibility with pubsub spec changes Ensure compatibility with pubsub spec changes regarding messageIDs Jul 25, 2020
@vasco-santos
Copy link
Member

@rklaehn thanks for raising this. We will be working on this together with the gossipsub1.1 update

@vasco-santos vasco-santos added the status/ready Ready to be worked label Jul 28, 2020
@vasco-santos vasco-santos mentioned this issue Jul 28, 2020
Closed
@achingbrain
Copy link
Member

Gossipsub message ids are bytes so all good here, I think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rklaehn @achingbrain @vasco-santos