This repository has been archived by the owner on Aug 23, 2019. It is now read-only.
fix: dont use peerinfo distinct #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
requested review from
alanshaw and
vasco-santos
and removed request for
alanshaw
dirkmc
reviewed
Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces libp2p/js-peer-info#78
This is a workaround, as noted in the code comments, until https://github.com/libp2p/interface-transport/issues/41 is completed and we can allow transports to do their own unique filtering.
This removes our dependency on the
PeerInfo.multiaddrs.distinct()method, which is a patch for this same issue. This attempts to improve on the logic there by being more specific about port uniqueness, which should also allow us to implement multiple port 0 listens, #227.