Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Implement the same Crypto Puzzle that websocket-star has #128

Open
daviddias opened this issue Nov 27, 2017 · 7 comments
Open

Implement the same Crypto Puzzle that websocket-star has #128

daviddias opened this issue Nov 27, 2017 · 7 comments
Assignees
Labels
P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

daviddias commented Nov 27, 2017

Following ipfs/js-ipfs#1095 (comment)

@mkg20001 is this something you could contribute?

@mkg20001
Copy link
Member

Sure but also libp2p/js-peer-id#71 needs to be fixed as the server does not have "catch all type validation" which prevents the server crashes in ws-star

@daviddias
Copy link
Member Author

@mkg20001 deps updated. Wanna implement that crypto puzzle? :)

@mkg20001
Copy link
Member

mkg20001 commented Dec 1, 2017

@diasdavid Yes

@daviddias daviddias added the status/ready Ready to be worked label Feb 5, 2018
@daviddias daviddias added the P2 Medium: Good to have, but can wait until someone steps up label Feb 5, 2018
@mkg20001
Copy link
Member

mkg20001 commented Feb 5, 2018

How about just rewriting wrtc-star to use the new protobuf+libp2p stuff that ws-star will be using? I think that would be easier than to mess even more with sio.

@daviddias
Copy link
Member Author

Wait on libp2p/js-libp2p#159, it will enable the use of p2p-circuit for both *-star transports

@mkg20001
Copy link
Member

mkg20001 commented Feb 6, 2018

Sure but wasn't wrtc star about the fact the webrtc needs signalling to build up webrtc connection independently of p2p-circuit?

@mkg20001
Copy link
Member

mkg20001 commented Feb 7, 2018

If webrtc star is about using the webrtc protocol rather then the relaying of the connection then it should be independent from signaling servers.
Addresses would then look like <actual-addr>/webrtc/ipfs/<peer-id> similar to how the websocket protocol addresses look.
ws-star could be actually renamed to discovery, discovery-star or web-mDNS (because as p2p-ciruit handles relay anyway it's only needed for discovery)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants