This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
fix: crypto challenge stall due to callback usage of async/await #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async/await update (#35) did not fully migrate away from callbacks. It was still using callbacks for some of the crypto library usage. This caused crypto challenge to fail.
Note on testing: I didn't add a new test for this as we are planning to migrate the rendezvous server into https://github.com/libp2p/js-libp2p-websocket-star, per libp2p/js-libp2p-websocket-star#73, and the websocket-star test suite does catch this issue. I've created a PR there to demonstrate the fix.
fixes: #36