fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some engines, resulting in _update consuming a lot of CPU.
libp2p · Oct 14, 2019 · 93a1e42 · 93a1e42
1 parent 35aa45c
commit 93a1e42
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/switch/stats/stat.js b/src/switch/stats/stat.js
@@ -139,10 +139,10 @@ class Stats extends EventEmitter {
     this._timeout = null
     if (this._queue.length) {
       let last
-      while (this._queue.length) {
-        const op = last = this._queue.shift()
-        this._applyOp(op)
+      for (last of this._queue) {
+        this._applyOp(last)
       }
+      this._queue = []
 
       this._updateFrequency(last[2]) // contains timestamp of last op