Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like a typo in DHT setup #151

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Looks like a typo in DHT setup #151

merged 1 commit into from
Jan 16, 2018

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Jan 12, 2018

I think there was a typo that would have ignored passed options and fallback to defaults for DHT datastore.

I think there was a typo that would have ignored passed options and fallback to defaults for DHT datastore.
@ghost
Copy link

ghost commented Jan 12, 2018

:')

Copy link
Member

@dryajov dryajov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daviddias daviddias merged commit 61bebd1 into libp2p:master Jan 16, 2018
@daviddias
Copy link
Member

thanks @Gozala :)

maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants