Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @libp2p/interface-connection #1683

Closed
wemeetagain opened this issue Apr 13, 2023 · 2 comments
Closed

Update @libp2p/interface-connection #1683

wemeetagain opened this issue Apr 13, 2023 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@wemeetagain
Copy link
Member

The latest @libp2p/tcp (v6.2.0) isn't compatible with the latest libp2p (v0.43.4), seemingly because @libp2p/interface-connection needs to be upgraded throughout the ecosystem to v4.0.0.
@wemeetagain wemeetagain added the need/triage Needs initial labeling and prioritization label Apr 13, 2023
@achingbrain
Copy link
Member

achingbrain commented Apr 17, 2023 •
edited
Loading

libp2p 0.44 shipped which should restore balance to the force but agree we need a better way of managing this.

The logical place to put these things is libp2p, but the core objection here is not having components depend on lib2p directly because it creates a circular dependency.

Maybe after #1563 we could split all the components/interop/examples out into a monorepo setup that would remove the dependencies on tcp etc from libp2p and make the libp2p module itself so thin dependency-wise that it wouldn’t be a big deal?

Not 100% sure, might need some experimentation and thought.

@achingbrain
Copy link
Member

Will be fixed by #824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achingbrain @wemeetagain