Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for disabling AutoNat #1684

Closed
p-shahi opened this issue Apr 14, 2023 · 2 comments
Closed

Allow for disabling AutoNat #1684

p-shahi opened this issue Apr 14, 2023 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@p-shahi
Copy link
Member

p-shahi commented Apr 14, 2023

AutoNat need not run as a default libp2p service, we should either disable it by default or allow for disabling it.
Ref: libp2p/universal-connectivity#45
@p-shahi p-shahi added the need/triage Needs initial labeling and prioritization label Apr 14, 2023
@achingbrain
Copy link
Member

Agree that you should be able to disable it in the name of smaller surface areas for attacks, but what's the problem autonat is causing?

@p-shahi p-shahi moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Apr 25, 2023
@maschad maschad mentioned this issue Apr 28, 2023
Merged
@p-shahi p-shahi removed this from js-libp2p May 2, 2023
@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p May 23, 2023
@maschad
Copy link
Member

maschad commented May 23, 2023

Closed in https://www.github.com/libp2p/js-libp2p/issues/1563

@maschad maschad closed this as completed May 23, 2023
@github-project-automation github-project-automation bot moved this from 🥞Weekly Candidates/Discuss🎙 to 🎉Done in js-libp2p May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@achingbrain @maschad @p-shahi