New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: peerStore returns multiaddrs for a peer with peerIds postfixed where necessary. #1959

Closed

SgtPooki opened this issue Aug 11, 2023 · 0 comments

Labels

Member

SgtPooki commented Aug 11, 2023

When we get a peer from the peer store, we should be able to assume the multiaddrs need no modification. However, this is only sometimes true.

Some cases where it's not true:

p2p-circuit multiaddrs

References:

SgtPooki added the need/triage label

This was referenced Aug 11, 2023

fix: recognize p2p-circuit addresses without trailing peerId multiformats/js-multiaddr-matcher#2

Closed

bug: Circuit addresses without trailing peerId are not recognized. multiformats/js-multiaddr-matcher#3

Closed

feat: returned peer multiaddrs include peerIds #1961

Closed

SgtPooki closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment