Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Add component level performance benchmarks per PR #2120

Open
Tracked by #2118
maschad opened this issue Oct 3, 2023 · 1 comment
Open
Tracked by #2118

perf: Add component level performance benchmarks per PR #2120

maschad opened this issue Oct 3, 2023 · 1 comment
Labels
kind/discussion Topical discussion; usually not changes to codebase need/analysis Needs further analysis before proceeding

Comments

@maschad
Copy link
Member

maschad commented Oct 3, 2023 •
edited
Loading

As discussed in pl-strflt.notion.site/js-libp2p-perf-benchmarking-f7c42f96cbd44799a321347f6c15c8d4?pvs=4

In order to detect performance regressions at the component level, it may be useful to run component level benchmarks per PR. We've seen scenarios where mplex is more performant than yamux, despite mplex being deprecated. We could leverage the existing perf implementation and a Github action to create a comment such as this one ChainSafe/lodestar#6004 (comment)
@maschad maschad added need/triage Needs initial labeling and prioritization and removed need/triage Needs initial labeling and prioritization labels Oct 3, 2023
@maschad maschad added this to js-libp2p Oct 3, 2023
@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Oct 3, 2023
@maschad maschad mentioned this issue Oct 3, 2023
Open
@maschad maschad changed the title perf: integrate performance benchmarks perf: Add PR level performance benchmarks Oct 3, 2023
@maschad maschad added kind/discussion Topical discussion; usually not changes to codebase need/analysis Needs further analysis before proceeding labels Oct 3, 2023
@maschad maschad changed the title perf: Add PR level performance benchmarks perf: Add component level performance benchmarks per PR Oct 3, 2023
@maschad maschad moved this from 🥞Weekly Candidates/Discuss🎙 to 🛠️ Todo in js-libp2p Nov 7, 2023
@achingbrain achingbrain mentioned this issue May 14, 2024
Closed
@achingbrain achingbrain moved this from 🛠️ Todo to 🤨Needs Investigation in js-libp2p May 14, 2024
@dhuseby dhuseby moved this from 🤨Needs Investigation to 🛠️ Todo in js-libp2p May 14, 2024
@dhuseby
Copy link
Contributor

dhuseby commented May 14, 2024

Add similar benchmarking that lodestar has but at the component level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/discussion Topical discussion; usually not changes to codebase need/analysis Needs further analysis before proceeding
Projects
js-libp2p
Status: 🛠️ Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhuseby @maschad