Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch unhandled promise rejection in WebTransport muxer #2566

Merged
merged 1 commit into from
May 28, 2024

Conversation

achingbrain
Copy link
Member

If the WebTransport session has closed, trying to read new stream can cause the promise to reject, printing an error in the console.

This is non-fatal for browsers but let's catch and log the error instead.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

If the WebTransport session has closed, trying to read new stream
can cause the promise to reject, printing an error in the console.

This is non-fatal for browsers but let's catch and log the error
instead.
@achingbrain achingbrain requested a review from a team as a code owner May 28, 2024 17:11
@achingbrain achingbrain merged commit f4e572c into main May 28, 2024
24 checks passed
@achingbrain achingbrain deleted the fix/catch-uhe-in-wt-muxer branch May 28, 2024 17:31
@achingbrain achingbrain mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant