Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only mark a connection as transient if the relay has applied limits #2575

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

achingbrain
Copy link
Member

In go-libp2p, transient connections are judged based on whether the relay node has restrictions on the current connection. Reference code: https://github.com/libp2p/go-libp2p/blob/fccfbe7a4b6841325100038b83f86cd4e097b9a1/p2p/protocol/circuitv2/client/dial.go#L181

This submission aligns js-libp2p logic with go-libp2p logic.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner June 6, 2024 08:21
@achingbrain achingbrain merged commit 4bd8e4f into main Jun 6, 2024
24 checks passed
@achingbrain achingbrain deleted the fix/mark-connection-transient-based-on-limits branch June 6, 2024 09:27
@achingbrain achingbrain mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants