Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle-size #298

Merged
merged 8 commits into from
Feb 21, 2019
Merged

fix: bundle-size #298

merged 8 commits into from
Feb 21, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Dec 17, 2018

372.86 210.34 -43.58740546%

Big wins here, and this will get even smaller wait for the next episodes :)

@ghost ghost assigned hugomrdias Dec 17, 2018
@ghost ghost added the status/in-progress In progress label Dec 17, 2018
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser test suites are failing across most of these bundle size PRs. This is likely an issue with the aegir branch being used.

src/config.js Outdated Show resolved Hide resolved
src/config.js Show resolved Hide resolved
@hugomrdias
Copy link
Member Author

@jacobheun this is ready to review/merge

@jacobheun jacobheun merged commit d497961 into master Feb 21, 2019
@ghost ghost removed the status/in-progress In progress label Feb 21, 2019
@jacobheun jacobheun deleted the fix/bundle-size branch February 21, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants