-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bundle-size #298
Merged
Merged
fix: bundle-size #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
suggested changes
Dec 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Browser test suites are failing across most of these bundle size PRs. This is likely an issue with the aegir branch being used.
vasco-santos
suggested changes
Dec 18, 2018
alanshaw
suggested changes
Jan 3, 2019
hugomrdias
force-pushed
the
fix/bundle-size
branch
from
January 11, 2019 17:41
f303e7c
to
73b0c18
Compare
hugomrdias
force-pushed
the
fix/bundle-size
branch
from
February 21, 2019 15:17
73b0c18
to
e660a65
Compare
@jacobheun this is ready to review/merge |
jacobheun
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
372.86 210.34 -43.58740546%
Big wins here, and this will get even smaller wait for the next episodes :)