Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): improve flakey random walk discovery test #574

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Feb 28, 2020

The test previously had each of the 3 peers running random walk, and started the local libp2p node after the connections were made.

This isolates the random walking to only the local node to ensure it is the only node performing active discovery.

Resolves #560

@jacobheun jacobheun marked this pull request as ready for review February 28, 2020 12:54
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobheun jacobheun merged commit f4ec355 into master Feb 28, 2020
@jacobheun jacobheun deleted the test/flakey-disco branch February 28, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Fix flakey DHT peer discovery test on CI on Linux 10
2 participants