-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: put a /browser and a /nodejs bundles at easy access #578
Comments
IMO its better to do file swaps with package.json browser property as we have in ipfs, that way we can control over what gets executed. Having different entry points as several down sides:
Having good config defaults plus some specific profile configs that we can controls with file swaps, would give a more easy and stable experience for our users. |
FYI me and @jacobheun have been talking since the refactor about the need to improve config! @jacobheun made an initial proposal on #576 and I feel that his proposal seems the way to go (did not read in deep yet, but from we discussed earlier, I think we are well aligned)
@daviddias FYI with the refactor we went away from the "bundle" naming as it was not being well interpreted by the community and we are having several issues on the naming. I wrote a libp2p/js-libp2p/CONFIGURATION.md and libp2p/js-libp2p/GETTING_STARTED.md that aim to help new users to go through the configuration. Even though this is a burden for users, and that's why we started discussing improving the configuration.
@hugomrdias |
I don't really understand why we can't use file swap for a default config. In the Example Configurations from jacob you could expose a default config This Plus others profiles like the pubsub example. |
@hugomrdias in that case it make sense yes! 👍 |
I'm fine with both. The goal is to give users a quick way to get started. @hugomrdias wanna take a stab at that PR following your pattern? |
Closing as we will work on this in the context of #576 |
Currently, getting a browser bundle and a node bundle takes a lot of extra steps. For beginners, it would be super good if they could just do:
require('libp2p/browser') and require('libp2p/nodejs') and get an all set libp2p bundle with the best configs™
The text was updated successfully, but these errors were encountered: