Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make circuit relay listening addresses more forgiving #604

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

jacobheun
Copy link
Contributor

  • Makes the delegate tests less restrictive, we don't need to mock the query params, validation should be done in the modules themselves. This should make libp2p tests more resilient to non breaking, additive changes.

This makes setting a relay address a bit more lenient. You can now use:

/p2p-circuit/ip4/0.0.0.0/tcp/9090/p2p/QmRelay
// or
/ip4/0.0.0.0/tcp/9090/p2p/QmRelay/p2p-circuit

You could previously only do the former. Both will result in the same announced address: /ip4/0.0.0.0/tcp/9090/p2p/QmRelay/p2p-circuit/p2p/QmOurId

@jacobheun
Copy link
Contributor Author

windows test failures are due to an unrelated bug with the ipfs http client that's being fixed

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobheun jacobheun merged commit e192eb6 into master Apr 14, 2020
@jacobheun jacobheun deleted the fix/circuit-listening branch April 14, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants