Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meta] Crypto updates #615

Closed
8 of 11 tasks
jacobheun opened this issue Apr 24, 2020 · 5 comments
Closed
8 of 11 tasks

[Meta] Crypto updates #615

jacobheun opened this issue Apr 24, 2020 · 5 comments
Assignees
@jacobheun
Labels
Epic exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/in-progress In progress

Comments

@jacobheun
Copy link
Contributor

jacobheun commented Apr 24, 2020 •
edited
Loading

This is a meta issue to track work I will be doing around various crypto updates in libp2p.

Noise

We are planning on deprecating libp2p-secio in favor of libp2p-noise. ETA's are based on current estimated timelines of IPFS version updates and are subject to change.

  • js-libp2p uses libp2p-noise in all tests
  • js-libp2p uses libp2p-noise in all examples
  • Integrate libp2p-noise into js-ipfs as fallback for libp2p-secio (ETA: June 23rd)
    • Remove support for libp2p-secio in js-ipfs (ETA: Aug 11th)

ed25519 Keys (ETA: js-libp2p@0.29)

Big Fixes
@jacobheun jacobheun added the Epic label Apr 24, 2020
@jacobheun jacobheun self-assigned this Apr 24, 2020
@jacobheun jacobheun added exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP status/ready Ready to be worked labels Apr 24, 2020
@jacobheun
Copy link
Contributor Author

cc @achingbrain @hugomrdias @vasco-santos

@jacobheun jacobheun added status/in-progress In progress and removed status/ready Ready to be worked labels Apr 27, 2020
@jacobheun jacobheun mentioned this issue Apr 27, 2020
Closed
@vasco-santos
Copy link
Member

@jacobheun we should default PeerId.create to use ed25519 keys as well. When would be a good time for that in this timeline?

@vasco-santos vasco-santos mentioned this issue Jun 8, 2020
Open
@jacobheun
Copy link
Contributor Author

@jacobheun we should default PeerId.create to use ed25519 keys as well. When would be a good time for that in this timeline?

@vasco-santos we could time a breaking change of PeerId with the 0.29 work so that we time that with signed peer records.

@vasco-santos vasco-santos mentioned this issue Jun 16, 2020
Merged
@jacobheun
Copy link
Contributor Author

The major outstanding issue left for this is Keychain support for ed25519 keys, which is due to a lack of import/export support in js-libp2p-crypto.

@jacobheun jacobheun added P3 Low: Not priority right now and removed P0 Critical: Tackled by core team ASAP labels Feb 26, 2021
@wemeetagain
Copy link
Member

I believe all outstanding items have been implemented. Feel free to reopen if not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobheun jacobheun

Labels
Epic exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature P3 Low: Not priority right now status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jacobheun @wemeetagain @vasco-santos @p-shahi