fix(identify): make agentversion dynamic and add it to the peerstore #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
approved these changes
Aug 4, 2020
| @@ -175,6 +175,7 @@ class IdentifyService { | |||
| // Update peers data in PeerStore | |||
| this.peerStore.addressBook.set(id, listenAddrs.map((addr) => multiaddr(addr))) | |||
| this.peerStore.protoBook.set(id, protocols) | |||
| this.peerStore.metadataBook.set(id, 'AgentVersion', Buffer.from(message.agentVersion)) | |||
There was a problem hiding this comment.
I was thinking that metadataBook would only be used by the application layer.
I think it is useful to store the agentVersion, but I wonder if we should have a way of identifying who stored data in the metadataBook
There was a problem hiding this comment.
If there is a need to separate them in the future we could make an internal book for libp2p but I'd prefer to avoid that unless a problem arises. Worst case scenario users/apps can override values, but if we document what libp2p stores there I think it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AgentVersion in identify shouldn't be static. In go-libp2p the AgentVersion is generated by the application name and version, so for go-ipfs this looks like
go-ipfs/<version>. Ideally we would replicate this, however this is a trickier to handle in JS as we need to account for browser usage. At the very least we need to default to the js-libp2p version, so this adds that basic level of support.This is extremely helpful for understanding what versions are being used on the network, which helps us when determining upgrade strategies and change rollouts on the network.
go-libp2p also tracks the AgentVersion of peers in the metadata book, so I added that here as well, which is necessary for actually checking this data (we were previously ignoring this).