-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow certain keychain operations without a password #726
Conversation
I've update this to not require a password. I'll create an issue for supporting a password rotate feature. We should be able to set new passwords on they keychain. This will give us the ability to start without one and then "rotate" to one later. |
@achingbrain is this enough for I believe that this needs to be changed: https://github.com/libp2p/js-libp2p/blob/master/src/index.js#L85 |
Listing, removing, renaming etc keys do not require a password so the user should not be required to provide one. This means we don't have to prompt the user to create a password when they aren't going to do any operations that require a password.
088b782
to
386c3d3
Compare
Good catch, I rebased with master and added a test for libp2p creation without a keychain pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
FYI I verified it fixes js-ipfs, ipfs/js-ipfs#3212. I'm working on bubbling it up there. |
Thanks for pulling this across the line! |
Listing, removing, renaming etc keys do not require a password so
the user should not be required to provide one.
This means we don't have to prompt the user to create a password
when they aren't going to do any operations that require a password.