Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event emitter types with local types #864

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

vasco-santos
Copy link
Member

This PR fixes the current broken build job of aegir.

EventEmitter types were broken in DefinitelyTyped/DefinitelyTyped#50266. This was resulting in the following errors:

src/connection-manager/latency-monitor.js:2:1 - error TS9006: Declaration emit for this file requires using private name 'EventEmitter' from module '"events"'. An explicit type annotation may unblock declaration emit.

2 'use strict'
  ~~~~~~~~~~~~

src/connection-manager/visibility-change-emitter.js:7:1 - error TS9006: Declaration emit for this file requires using private name 'EventEmitter' from module '"events"'. An explicit type annotation may unblock declaration emit.

7 'use strict'
  ~~~~~~~~~~~~

src/index.js:1:1 - error TS9006: Declaration emit for this file requires using private name 'EventEmitter' from module '"events"'. An explicit type annotation may unblock declaration emit.

1 'use strict'
  ~~~~~~~~~~~~

src/metrics/stats.js:2:1 - error TS9006: Declaration emit for this file requires using private name 'EventEmitter' from module '"events"'. An explicit type annotation may unblock declaration emit.

2 'use strict'
  ~~~~~~~~~~~~

src/peer-store/index.js:1:1 - error TS9006: Declaration emit for this file requires using private name 'EventEmitter' from module '"events"'. An explicit type annotation may unblock declaration emit.

1 'use strict'
  ~~~~~~~~~~~~

This is a temporary fix and we should follow up in the next libp2p breaking change with #863

@vasco-santos vasco-santos force-pushed the fix/event-emitter-types-with-local-types branch from 0b49238 to 3491306 Compare January 18, 2021 15:48
@vasco-santos vasco-santos force-pushed the fix/event-emitter-types-with-local-types branch from 3491306 to a9748a6 Compare January 18, 2021 15:50
@vasco-santos vasco-santos merged commit 6c41e30 into master Jan 18, 2021
@vasco-santos vasco-santos deleted the fix/event-emitter-types-with-local-types branch January 18, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants