Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libp2p dialer should try to find multiaddrs for a given peer if it does not know any #901

Closed
vasco-santos opened this issue Mar 11, 2021 · 1 comment
Closed

Libp2p dialer should try to find multiaddrs for a given peer if it does not know any #901

vasco-santos opened this issue Mar 11, 2021 · 1 comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@vasco-santos
Copy link
Member

  • Version: N/A
  • Platform: N/A
  • Subsystem: Dialer

Type: Enhancenment

Description:

We currently recommend users to do libp2p.dial(peerId) to dial peers. This will obviously fail if multiaddrs for the given peer were not previously added to the addressBook (either manually, or via a discovery mechanism/DHT/rendezvous...)

If libp2p has a peer-routing module, it should perform a lookup in order to try to find multiaddrs for the given peer, before simply failing with "no available multiaddrs for the given peer"

Context: libp2p/js-libp2p-interfaces#85
@vasco-santos vasco-santos added the status/ready Ready to be worked label Mar 11, 2021
@vasco-santos vasco-santos added help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature labels Apr 1, 2021
@vasco-santos vasco-santos mentioned this issue Apr 27, 2021
Closed
@vasco-santos vasco-santos added the exp/intermediate Prior experience is likely helpful label Nov 12, 2021
@maschad
Copy link
Member

maschad commented Sep 28, 2023

This beyond the scope of the dial functionality, will not fix.

@maschad maschad closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vasco-santos @maschad